libs/rt-thread
libs/rt-thread
4
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[finsh]Minor optimization in finsh_compiler.c

Browse Source 
The code just clean the first member of array 'finsh_vm_stack', but it works well in the past years, 
            memset(&finsh_vm_stack[0], 0, sizeof(finsh_vm_stack[0]));
    Is it better to re-code as below, it will be more readable and robust:
            memset(&finsh_vm_stack[0], 0, sizeof(finsh_vm_stack));
This commit is contained in:
David Lin 2020-02-29 16:53:44 +08:00 committed by GitHub
parent 02722864d6
commit fac95192ea
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
components/finsh/finsh_compiler.c
View File

@ -890,7 +890,7 @@ int finsh_compiler_run(struct finsh_node* node)
/* clean text segment and vm stack */
memset(&text_segment[0], 0, sizeof(text_segment));
memset(&finsh_vm_stack[0], 0, sizeof(finsh_vm_stack[0]));
memset(&finsh_vm_stack[0], 0, sizeof(finsh_vm_stack));
/* reset compile stack pointer and pc */
finsh_compile_sp = &finsh_vm_stack[0];