libs/rt-thread
libs/rt-thread
4
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

TC: do not use rt_sem_trytake to clean the sem

Browse Source 
There can be a race condition that the sem has alread been detached
after we did the cleanup. Besides, there is a RT_IPC_CMD_RESET command
in rt_sem_control which is more clear in setting the sem values.
This commit is contained in:
Grissiom 2013-12-18 20:52:55 +08:00
parent cb347f5af0
commit e9e8e3f3ca
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
examples/kernel/tc_comm.c
View File

@ -40,6 +40,8 @@ void tc_thread_entry(void* parameter)
tick = index->func(); tick = index->func();
if (tick > 0) if (tick > 0)
{ {
/* Make sure we are going to be blocked. */
rt_sem_control(&_tc_sem, RT_IPC_CMD_RESET, 0);
rt_sem_take(&_tc_sem, tick * _tc_scale); rt_sem_take(&_tc_sem, tick * _tc_scale);
if (_tc_cleanup != RT_NULL) if (_tc_cleanup != RT_NULL)
@ -49,8 +51,6 @@ void tc_thread_entry(void* parameter)
_tc_cleanup = RT_NULL; _tc_cleanup = RT_NULL;
} }
rt_sem_trytake(&_tc_sem);/* by nl1031 */
if (_tc_stat & TC_STAT_FAILED) if (_tc_stat & TC_STAT_FAILED)
rt_kprintf("TestCase[%s] failed\n", _tc_current); rt_kprintf("TestCase[%s] failed\n", _tc_current);
else else