libs/rt-thread
libs/rt-thread
4
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

log_trace: fix the memmove use

Browse Source 
The first parameter of memmove is the dst, not src. Besides, fix the
wrong move size.
This commit is contained in:
Grissiom 2013-10-11 17:23:30 +08:00
parent 786a5541a3
commit d0251a523a
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
components/utilities/logtrace/log_trace.c
View File

@ -93,6 +93,9 @@ static struct log_trace_session* _lg_lookup_session(log_trace_idnum_t num)
last = _the_sess_nr; last = _the_sess_nr;
do { do {
unsigned int i = (first + last)/2; unsigned int i = (first + last)/2;
RT_ASSERT(_the_sessions[i]);
if (_the_sessions[i]->id.num == num) if (_the_sessions[i]->id.num == num)
{ {
/* there is no need to protect the _cache because write a pointer /* there is no need to protect the _cache because write a pointer
@ -135,7 +138,8 @@ rt_err_t log_trace_register_session(struct log_trace_session *session)
{ {
if (_the_sessions[i]->id.num > session->id.num) if (_the_sessions[i]->id.num > session->id.num)
{ {
rt_memmove(_the_sessions+i, _the_sessions+i+1, _the_sess_nr-i); rt_memmove(_the_sessions+i+1, _the_sessions+i,
(_the_sess_nr-i)*sizeof(&_the_sessions[0]));
_the_sessions[i] = session; _the_sessions[i] = session;
break; break;
} }