libs/rt-thread
libs
/
rt-thread
4
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[libc][ctime] move null pointer check before dereference 

This null check was redundant because the pointer timep was
dereferenced in any case.
This commit is contained in:
Mingjie Shen 2023-06-13 18:10:03 -04:00 committed by Man, Jianting (Meco)
parent 6198eea6c7
commit c7ad493b9a
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
components/libc/compilers/common/ctime.c
View File

@ -177,7 +177,7 @@ static int set_timeval(struct timeval *tv)
struct tm *gmtime_r(const time_t *timep, struct tm *r) struct tm *gmtime_r(const time_t *timep, struct tm *r)
{ {
int i; int i;
int work = *timep % (SPD); int work;
if(timep == RT_NULL || r == RT_NULL) if(timep == RT_NULL || r == RT_NULL)
{ {
@ -187,6 +187,7 @@ struct tm *gmtime_r(const time_t *timep, struct tm *r)
rt_memset(r, RT_NULL, sizeof(struct tm)); rt_memset(r, RT_NULL, sizeof(struct tm));
work = *timep % (SPD);
r->tm_sec = work % 60; r->tm_sec = work % 60;
work /= 60; work /= 60;
r->tm_min = work % 60; r->tm_min = work % 60;