From 51c4a3aeaea9947701e03abd085afc3eb07df6a8 Mon Sep 17 00:00:00 2001 From: Grissiom Date: Thu, 28 Aug 2014 12:27:47 +0800 Subject: [PATCH] tools/building: remove the use of startupinfo The startupinfo does not have any visible effects on the building process and some old Python version does not have it at all. So remove it for the seek of simple. Tested `scons -j4` in a dual core virtual machine. --- tools/building.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/tools/building.py b/tools/building.py index 3572daabbe..ad5df12bcc 100644 --- a/tools/building.py +++ b/tools/building.py @@ -27,8 +27,6 @@ class Win32Spawn: newargs = string.join(args[1:], ' ') cmdline = cmd + " " + newargs - startupinfo = subprocess.STARTUPINFO() - startupinfo.dwFlags |= subprocess.STARTF_USESHOWWINDOW # Make sure the env is constructed by strings _e = {k: str(v) for k, v in env.items()} @@ -40,8 +38,7 @@ class Win32Spawn: os.environ['PATH'] = _e['PATH'] try: - proc = subprocess.Popen(cmdline, env=_e, - startupinfo=startupinfo, shell=False) + proc = subprocess.Popen(cmdline, env=_e, shell=False) except Exception as e: print 'Error in calling:\n%s' % cmdline print 'Exception: %s: %s' % (e, os.strerror(e.errno))