mirror of
git://sourceware.org/git/newlib-cygwin.git
synced 2025-01-21 05:49:19 +08:00
18b4e0e518
The comparison c == FP_INFINITE causes the function to return +inf as it expects x = +inf to always be larger than y. This shortcut causes several issues as it also returns +inf for the following cases: - fdim(+inf, +inf), expected (as per C99): +0.0 - fdim(-inf, any non NaN), expected: +0.0 I don't see a reason to keep the comparison as all the infinity cases return the correct result using just the ternary operation.
37 lines
672 B
C
37 lines
672 B
C
/* Copyright (C) 2002 by Red Hat, Incorporated. All rights reserved.
|
|
*
|
|
* Permission to use, copy, modify, and distribute this software
|
|
* is freely granted, provided that this notice is preserved.
|
|
*/
|
|
|
|
#include "fdlibm.h"
|
|
|
|
#ifdef __STDC__
|
|
float fdimf(float x, float y)
|
|
#else
|
|
float fdimf(x,y)
|
|
float x;
|
|
float y;
|
|
#endif
|
|
{
|
|
if (__fpclassifyf(x) == FP_NAN) return(x);
|
|
if (__fpclassifyf(y) == FP_NAN) return(y);
|
|
|
|
return x > y ? x - y : 0.0;
|
|
}
|
|
|
|
#ifdef _DOUBLE_IS_32BITS
|
|
|
|
#ifdef __STDC__
|
|
double fdim(double x, double y)
|
|
#else
|
|
double fdim(x,y)
|
|
double x;
|
|
double y;
|
|
#endif
|
|
{
|
|
return (double) fdimf((float) x, (float) y);
|
|
}
|
|
|
|
#endif /* defined(_DOUBLE_IS_32BITS) */
|