4
0
mirror of git://sourceware.org/git/newlib-cygwin.git synced 2025-02-18 23:12:15 +08:00
Corinna Vinschen 6ed4753e77 rename: Refactor "new file already exists and rename fails" case
If newfile already exists and is in use, trying to overwrite it with
NtSetInformationFile(FileRenameInformation) fails exactly as if we
don't have the permissions to delete it.  Unfortunately the return code
is the same STATUS_ACCESS_DENIED, so we have no way to distinguish
these cases.  What we do here so far is to start a transaction to delete
newfile.  If this open fails with a transactional error we stop the
transaction and retry opening the file without transaction.

But, here's the problem: If newfile is in use, NtOpenFile(oldfile)
naturally does NOT fail with a transactional error.  Rather, the
subsequent call to unlink_nt(newfile) does, because there's another
handle open to newfile outside a transaction.  However, the code does
not check if unlink_nt fails with a transactional error and so fails
to retry without transaction.

This patch recifies the problem and checks unlink_nt's status as well.

Refactor code to get rid of goto into another code block.

Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
2017-01-12 22:42:11 +01:00
2016-06-23 15:54:55 -04:00
2016-06-23 15:54:55 -04:00
2016-08-19 10:32:23 +02:00
2015-03-09 20:53:11 +01:00
2016-06-23 15:54:55 -04:00
2016-03-22 10:25:20 +01:00
2016-03-22 10:25:20 +01:00
2016-06-23 15:54:55 -04:00
2016-06-23 15:54:55 -04:00
2016-06-23 15:54:55 -04:00
2016-06-23 15:54:55 -04:00
2016-03-22 10:25:20 +01:00
2016-03-22 10:25:20 +01:00
2016-03-22 10:25:20 +01:00
2016-03-22 10:25:20 +01:00
2010-01-09 21:11:32 +00:00
2014-02-05 13:17:47 +00:00
2010-01-09 21:11:32 +00:00
2010-01-09 21:11:32 +00:00
2016-06-23 15:54:55 -04:00
2016-06-23 15:54:55 -04:00
2016-03-22 10:25:20 +01:00
2016-03-22 10:25:20 +01:00
2016-03-22 10:25:20 +01:00

		   README for GNU development tools

This directory contains various GNU compilers, assemblers, linkers, 
debuggers, etc., plus their support routines, definitions, and documentation.

If you are receiving this as part of a GDB release, see the file gdb/README.
If with a binutils release, see binutils/README;  if with a libg++ release,
see libg++/README, etc.  That'll give you info about this
package -- supported targets, how to use it, how to report bugs, etc.

It is now possible to automatically configure and build a variety of
tools with one command.  To build all of the tools contained herein,
run the ``configure'' script here, e.g.:

	./configure 
	make

To install them (by default in /usr/local/bin, /usr/local/lib, etc),
then do:
	make install

(If the configure script can't determine your type of computer, give it
the name as an argument, for instance ``./configure sun4''.  You can
use the script ``config.sub'' to test whether a name is recognized; if
it is, config.sub translates it to a triplet specifying CPU, vendor,
and OS.)

If you have more than one compiler on your system, it is often best to
explicitly set CC in the environment before running configure, and to
also set CC when running make.  For example (assuming sh/bash/ksh):

	CC=gcc ./configure
	make

A similar example using csh:

	setenv CC gcc
	./configure
	make

Much of the code and documentation enclosed is copyright by
the Free Software Foundation, Inc.  See the file COPYING or
COPYING.LIB in the various directories, for a description of the
GNU General Public License terms under which you can copy the files.

REPORTING BUGS: Again, see gdb/README, binutils/README, etc., for info
on where and how to report problems.
Description
No description provided
Readme 156 MiB
Languages
C 61.5%
Makefile 19.6%
C++ 10.4%
Assembly 4.9%
M4 1%
Other 2.4%