mirror of
git://sourceware.org/git/newlib-cygwin.git
synced 2025-01-18 12:29:32 +08:00
e02866a1b4
A few files were missing headers for memset/malloc, likely missed
because the files don't directly call the functions, rather they
come in via macros in libc/include/sys/reent.h:
#define _REENT_CHECK(var, what, type, size, init) do { \
struct _reent *_r = (var); \
if (_r->what == NULL) { \
_r->what = (type)malloc(size); \
#define _REENT_CHECK_ASCTIME_BUF(var) \
_REENT_CHECK(var, _asctime_buf, char *, _REENT_ASCTIME_SIZE, \
memset((var)->_asctime_buf, 0, _REENT_ASCTIME_SIZE))
Without these fixes, implicit function signatures are provided,
which gcc warns could cause aliasing issues down the line:
../../../../../../../newlib-2.5.0/newlib/libc/time/asctime.c:62:3: warning: type of 'memset' does not match original declaration [-Wlto-type-mismatch]
/Volumes/code/external/newlib-cygwin/newlib/libc/include/string.h:29:7: note: return value type mismatch
_PTR _EXFUN(memset,(_PTR, int, size_t));
^
/Volumes/code/external/newlib-cygwin/newlib/libc/include/string.h:29:7: note: 'memset' was previously declared here
/Volumes/code/external/newlib-cygwin/newlib/libc/include/string.h:29:7: note: code may be misoptimized unless -fno-strict-aliasing is used
../../../../../../../newlib-2.5.0/newlib/libc/time/asctime.c:62:3: warning: type of 'malloc' does not match original declaration [-Wlto-type-mismatch]
/Volumes/code/external/newlib-cygwin/newlib/libc/include/malloc.h:37:13: note: return value type mismatch
extern _PTR malloc _PARAMS ((size_t));
^
/Volumes/code/external/newlib-cygwin/newlib/libc/include/malloc.h:37:13: note: 'malloc' was previously declared here
/Volumes/code/external/newlib-cygwin/newlib/libc/include/malloc.h:37:13: note: code may be misoptimized unless -fno-strict-aliasing is used
../../../../../../../newlib-2.5.0/newlib/libc/time/lcltime.c:58:3: warning: type of 'malloc' does not match original declaration [-Wlto-type-mismatch]
/Volumes/code/external/newlib-cygwin/newlib/libc/include/malloc.h:37:13: note: return value type mismatch
extern _PTR malloc _PARAMS ((size_t));
^
/Volumes/code/external/newlib-cygwin/newlib/libc/include/malloc.h:37:13: note: 'malloc' was previously declared here
/Volumes/code/external/newlib-cygwin/newlib/libc/include/malloc.h:37:13: note: code may be misoptimized unless -fno-strict-aliasing is used
../../../../../../../newlib-2.5.0/newlib/libc/string/strsignal.c:70:3: warning: type of 'malloc' does not match original declaration [-Wlto-type-mismatch]
/Volumes/code/external/newlib-cygwin/newlib/libc/include/malloc.h:37:13: note: return value type mismatch
extern _PTR malloc _PARAMS ((size_t));
^
/Volumes/code/external/newlib-cygwin/newlib/libc/include/malloc.h:37:13: note: 'malloc' was previously declared here
/Volumes/code/external/newlib-cygwin/newlib/libc/include/malloc.h:37:13: note: code may be misoptimized unless -fno-strict-aliasing is used
Including the proper headers elminates the implicit function
signatures and these warnings.
69 lines
1.3 KiB
C
69 lines
1.3 KiB
C
/*
|
|
* asctime.c
|
|
* Original Author: G. Haley
|
|
*
|
|
* Converts the broken down time in the structure pointed to by tim_p into a
|
|
* string of the form
|
|
*
|
|
* Wed Jun 15 11:38:07 1988\n\0
|
|
*
|
|
* Returns a pointer to the string.
|
|
*/
|
|
|
|
/*
|
|
FUNCTION
|
|
<<asctime>>---format time as string
|
|
|
|
INDEX
|
|
asctime
|
|
INDEX
|
|
_asctime_r
|
|
|
|
ANSI_SYNOPSIS
|
|
#include <time.h>
|
|
char *asctime(const struct tm *<[clock]>);
|
|
char *_asctime_r(const struct tm *<[clock]>, char *<[buf]>);
|
|
|
|
TRAD_SYNOPSIS
|
|
#include <time.h>
|
|
char *asctime(<[clock]>)
|
|
struct tm *<[clock]>;
|
|
char *asctime_r(<[clock]>)
|
|
struct tm *<[clock]>;
|
|
char *<[buf]>;
|
|
|
|
DESCRIPTION
|
|
Format the time value at <[clock]> into a string of the form
|
|
. Wed Jun 15 11:38:07 1988\n\0
|
|
The string is generated in a static buffer; each call to <<asctime>>
|
|
overwrites the string generated by previous calls.
|
|
|
|
RETURNS
|
|
A pointer to the string containing a formatted timestamp.
|
|
|
|
PORTABILITY
|
|
ANSI C requires <<asctime>>.
|
|
|
|
<<asctime>> requires no supporting OS subroutines.
|
|
*/
|
|
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
#include <time.h>
|
|
#include <_ansi.h>
|
|
#include <reent.h>
|
|
|
|
#ifndef _REENT_ONLY
|
|
|
|
char *
|
|
_DEFUN (asctime, (tim_p),
|
|
_CONST struct tm *tim_p)
|
|
{
|
|
struct _reent *reent = _REENT;
|
|
|
|
_REENT_CHECK_ASCTIME_BUF(reent);
|
|
return asctime_r (tim_p, _REENT_ASCTIME_BUF(reent));
|
|
}
|
|
|
|
#endif
|