mirror of
git://sourceware.org/git/newlib-cygwin.git
synced 2025-02-02 20:40:24 +08:00
573532df7f
On 31/07/15 10:34, Richard Earnshaw wrote: > On 31/07/15 10:28, Andre Vieira wrote: >> newlib/ChangeLog: >> 2015-07-28 Andre Vieira <andre.simoesdiasvieira@arm.com> >> >> * libc/sys/arm/sys/param.h: Include machine/param.h >> (HZ, NOFILE, PATHSIZE): Define. >> >> param_refactor_1.patch >> >> >> From abc2d5f3398721f6ca891b9581feaba58730b19c Mon Sep 17 00:00:00 2001 >> From: Andre Simoes Dias Vieira <andsim01@arm.com> >> Date: Tue, 28 Jul 2015 12:10:59 +0100 >> Subject: [PATCH 1/2] Moved param configuration to machine/param.h >> >> --- >> newlib/libc/sys/arm/sys/param.h | 12 ++++++++++-- >> 1 file changed, 10 insertions(+), 2 deletions(-) >> >> diff --git a/newlib/libc/sys/arm/sys/param.h b/newlib/libc/sys/arm/sys/param.h >> index adc066e9a8756e07edaaa8cadc79b5f05c996ac9..622c371972ab3c9dbb93ea5c51323a593e2a171a 100644 >> --- a/newlib/libc/sys/arm/sys/param.h >> +++ b/newlib/libc/sys/arm/sys/param.h >> @@ -3,9 +3,17 @@ >> #ifndef _SYS_PARAM_H >> # define _SYS_PARAM_H >> >> -# define HZ (100) >> -# define NOFILE (60) >> +#include <machine/param.h> >> + >> +#ifndef HZ >> +# define HZ (60) > > Why have you changed the value for HZ? It seems that, by convention, > ARM boards have always used 100. > > R. > >> +#endif >> +#ifndef NOFILE >> +# define NOFILE>(60) >> +#endif >> +#ifndef PATHSIZE >> # define PATHSIZE (1024) >> +#endif >> >> #define BIG_ENDIAN 4321 >> #define LITTLE_ENDIAN 1234 >> > Hi Richard, ARM's machine/param.h that is included in "#include <machine/param.h>", before the 'ifndef' already defines HZ to be 100. This file was already there, it was just not being used. I understand that this 'ifndef' might be confusing, though I decided to add it to mimic the behavior of the default sys/param.h. There is however an unrelated issue with this patch, a typo in the "#define NOFILE" that crept in there due to some copy pasting when splitting the patch. Here is a fixed version. BR, Andre newlib/ChangeLog: 2015-07-28 Andre Vieira <andre.simoesdiasvieira@arm.com> * libc/sys/arm/sys/param.h: Include machine/param.h (HZ, NOFILE, PATHSIZE): Define. From abc2d5f3398721f6ca891b9581feaba58730b19c Mon Sep 17 00:00:00 2001 From: Andre Simoes Dias Vieira <andsim01@arm.com> Date: Tue, 28 Jul 2015 12:10:59 +0100 Subject: [PATCH 1/2] Moved param configuration to machine/param.h
README for GNU development tools This directory contains various GNU compilers, assemblers, linkers, debuggers, etc., plus their support routines, definitions, and documentation. If you are receiving this as part of a GDB release, see the file gdb/README. If with a binutils release, see binutils/README; if with a libg++ release, see libg++/README, etc. That'll give you info about this package -- supported targets, how to use it, how to report bugs, etc. It is now possible to automatically configure and build a variety of tools with one command. To build all of the tools contained herein, run the ``configure'' script here, e.g.: ./configure make To install them (by default in /usr/local/bin, /usr/local/lib, etc), then do: make install (If the configure script can't determine your type of computer, give it the name as an argument, for instance ``./configure sun4''. You can use the script ``config.sub'' to test whether a name is recognized; if it is, config.sub translates it to a triplet specifying CPU, vendor, and OS.) If you have more than one compiler on your system, it is often best to explicitly set CC in the environment before running configure, and to also set CC when running make. For example (assuming sh/bash/ksh): CC=gcc ./configure make A similar example using csh: setenv CC gcc ./configure make Much of the code and documentation enclosed is copyright by the Free Software Foundation, Inc. See the file COPYING or COPYING.LIB in the various directories, for a description of the GNU General Public License terms under which you can copy the files. REPORTING BUGS: Again, see gdb/README, binutils/README, etc., for info on where and how to report problems.