It's unclear why this was added originally, but assuming it was needed
20 years ago, it shouldn't be explicitly required nowadays. Current
versions of autotools already take care of exporting LDFLAGS to the
Makefile as needed (things are actually getting linked). That's why
the configure diffs show LDFLAGS still here, but shifted to a diff
place in the output list. A few dirs stop exporting LDFLAGS, but
that's because they don't do any linking, only compiling, so it's
correct.
As for the use of $ldflags instead of the standard $LDFLAGS, I can't
really explain that at all. Just use the right name so users don't
have to dig into why their setting isn't respected, and then use a
non-standard name instead. Adjust the testsuite to match.
Regression testing newlib in conjunction with libgloss and
--enable-multilib can result in incompatible multilib versions of
newlib and libgloss being used during link.
This manifests on ARM target when newlib regression is run using a
GCC configured using --with-multilib-list=aprofile
With this configuration many of the multilib variants built are
mutually incompatible.
The issue is that the newlib dejagnu foo iterates each multilib
variant and correctly chooses the appropriate newlib variant but
always chooses the root/base libgloss variant.
The implementation of newlib/testsuite/lib/flags.exp contains the
following fragment:
set target_build_path "$objdir/$multibuildtop.."
The effect of this fragment is to explicitly select the root version
of libgloss, irrespective of the current multilib.
Digging around in VC it appears that the original implementation of
multlib magic came into the tree back in 2002 with:
6e9d950a (Thomas Fitzsimmons 2002-05-01 17:06:25 +0000 39)
In this initial version of multilib support, newlib was multilib
capable, but libgloss was not multilib capable, hence the necessity to
explicitly select the root libgloss version.
Subsequently flags.exp was modified to support out of tree testing:
cec1d3b4 (Jeff Johnston 2005-07-05 00:11:50 +0000 25)
This change is orthogonal to this issue, its effect is to exit early
in none multilib configurations.
Subsequently libgloss gained --enable-multilib support, the relevant
change is:
https://sourceware.org/ml/newlib/2006/msg00440.html
commit 00a4b31ad0
Author: Jeff Johnston <jjohnstn@redhat.com>
Date: Wed May 10 20:51:41 2006 +0000
This change enabled multilib support throughout libgloss, but ommitted
to adjust the flag.exp behaviour which anchors the libgloss multilib
selection to the base version.
The attached patch adjusts flags.exp to select the current multilib
variant of libgloss.
2015-11-06 Marcus Shawcroft <marcus.shawcroft@arm.com>
* testsuite/lib/flags.exp (libgloss_link_flags): Drop multilibtop
from target_build_path.
* testsuite/lib/checkoutput.exp (newlib_check_output): Use test
names after PASS and FAIL which do not depend on source directory
name or on whether test passed or failed.
* testsuite/lib/passfail.exp (newlib_pass_fail): Likewise.
* Makefile.am (site.exp): Set tmpdir.
* Makefile.in: Regenerated.
* testsuite/lib/checkoutput.exp (newlib_check_output): Put
executables in $tmpdir.
* testsuite/lib/flags.exp (libgloss_link_flags): Use the original
libgloss version if not running in the build directory.
* testsuite/lib/newlib.exp (newlib_init): Put testglue.o in
$tmpdir.
* testsuite/lib/passfail.exp (newlib_pass_fail): Put executables
in $tmpdir.
* testsuite/lib/passfail.exp (newlib_pass_fail): Changed to
only issue one pass/fail message for a compile/link/execute.
* testsuite/newlib.elix/elix.exp: New file.
* testsuite/newlib.elix/tmmap.c: Ditto.
* testsuite/include/check.h: New header file to use with
test cases.
* testsuite/lib/newlib.exp: Add testsuite/include directory
to list of header files to use.
* testsuite/newlib.wctype/twctype.c: New test case for iswctype fns.
* testsuite/newlib.wctype/wctype.exp: New file.
procedure.
(newlib_pass_fail): Change to compile and run only one file.
* testsuite/newlib.locale/locale.exp: Use new
newlib_pass_fail_all procedure.
* testsuite/newlib.string/string.exp: Likewise.
only one pass or fail per test file. Trim \r's from output
values received from test programs. Remove support for named
tests.
* testsuite/newlib.locale/UTF-8.exp: Update to support new
newlib_check_output behaviour.
* testsuite/newlib.locale/UTF-8.c: Likewise.
jdoubleu
Mike Frysinger
Marcus Shawcroft
Jeff Johnston
Kazu Hirata
Thomas Fitzsimmons