Cygwin: console: Fix hangup of less on quit after the window is resized.

https://cygwin.com/pipermail/cygwin/2022-December/252737.html

If the less is started from non-cygwin shell and window size is
changed, it will hang-up when quitting. The cause of the proglem is
that less uses longjump() in signal handler. If the signal handler
is called while cygwin is acquiring the mutex, cygwin loses the
chance to release mutex. With this patch, the mutex is released
just before calling kill_pgrp() and re-acquired when kill_pgrp()
returns.

Reported-by: Gregory Mason <grmason@epic.com>
Signed-off-by: Takashi Yano <takashi.yano@nifty.ne.jp>
This commit is contained in:
Takashi Yano 2022-12-22 20:25:22 +09:00
parent 0a7bf8fc4c
commit f6e4e98d30
2 changed files with 8 additions and 0 deletions

View File

@ -928,7 +928,11 @@ fhandler_console::send_winch_maybe ()
if (wincap.has_con_24bit_colors () && !con_is_legacy if (wincap.has_con_24bit_colors () && !con_is_legacy
&& wincap.has_con_broken_tabs ()) && wincap.has_con_broken_tabs ())
fix_tab_position (get_output_handle ()); fix_tab_position (get_output_handle ());
/* longjmp() may be called in the signal handler like less,
so release input_mutex temporarily before kill_pgrp(). */
release_input_mutex ();
get_ttyp ()->kill_pgrp (SIGWINCH); get_ttyp ()->kill_pgrp (SIGWINCH);
acquire_input_mutex (mutex_timeout);
return true; return true;
} }
return false; return false;

View File

@ -3,3 +3,7 @@ Bug Fixes
- Fix an uninitialized variable having weird side-effects in path handling. - Fix an uninitialized variable having weird side-effects in path handling.
Addresses: https://cygwin.com/pipermail/cygwin/2022-December/252734.html Addresses: https://cygwin.com/pipermail/cygwin/2022-December/252734.html
- Fix hang-up of less on quit which occurs when it is started from non-cygwin
shell and window is resized.
Addresses: https://cygwin.com/pipermail/cygwin/2022-December/252737.html