From e5f2a0b1c8acdc00368dcc63d9d675d2683fceb7 Mon Sep 17 00:00:00 2001
From: Ken Brown <kbrown@cornell.edu>
Date: Wed, 28 Oct 2020 10:38:49 -0400
Subject: [PATCH] Cygwin: AF_UNIX: FIXME comments

---
 winsup/cygwin/fhandler_socket_unix.cc | 8 +++++---
 winsup/cygwin/select.cc               | 2 ++
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/winsup/cygwin/fhandler_socket_unix.cc b/winsup/cygwin/fhandler_socket_unix.cc
index c14673796..973e4ac0f 100644
--- a/winsup/cygwin/fhandler_socket_unix.cc
+++ b/winsup/cygwin/fhandler_socket_unix.cc
@@ -2569,9 +2569,11 @@ fhandler_socket_unix::create_cmsg_data (af_unix_pkt_hdr_t *packet,
   return true;
 }
 
-/* FIXME: If peer has set so_passcred, every packet we send should
-   contain SCM_CREDENTIALS ancillary data.
-   https://man7.org/linux/man-pages/man7/unix.7.html */
+/* FIXME: According to
+   https://man7.org/linux/man-pages/man7/unix.7.html, every packet we
+   send should contain SCM_CREDENTIALS ancillary data if peer has set
+   so_passcred.  But how can we know?  Should we arrange for the peer
+   to send this info in an admin packet? */
 ssize_t
 fhandler_socket_unix::sendmsg (const struct msghdr *msg, int flags)
 {
diff --git a/winsup/cygwin/select.cc b/winsup/cygwin/select.cc
index 33a3a6cf7..12ab62ab9 100644
--- a/winsup/cygwin/select.cc
+++ b/winsup/cygwin/select.cc
@@ -2077,6 +2077,8 @@ socket_unix_cleanup (select_record *, select_stuff *stuff)
   stuff->device_specific_socket_unix = NULL;
 }
 
+/* FIXME: Where in what follows should we be checking so_error? */
+
 select_record *
 fhandler_socket_unix::select_read (select_stuff *ss)
 {