libs/newlib-cygwin
libs/newlib-cygwin
4
0
Fork 0
mirror of git://sourceware.org/git/newlib-cygwin.git synced 2025-02-21 16:26:12 +08:00
Code Issues Projects Releases Wiki Activity

MinGW-Feature-Request [2222263]: Make getopt() GNU / BSD compatibile.

Browse Source
This commit is contained in:
Keith Marshall 2009-02-08 18:02:17 +00:00
parent f8471cd023
commit ce6ef36015
2 changed files with 39 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
winsup/mingw/ChangeLog
View File

@ -1,3 +1,11 @@
2009-02-08 Keith Marshall <keithmarshall@users.sourceforge.net>
MinGW-Feature-Request [2222263]: Make getopt() GNU / BSD compatibile.
(Requested by Robert Riebisch)
* mingwex/getopt.c (getopt_parse): Track external increments of...
(optind): ...this global variable.
2009-01-10 Chris Sutcliffe <ir0nh34d@users.sourceforge.net> 2009-01-10 Chris Sutcliffe <ir0nh34d@users.sourceforge.net>
* include/_mingw.h: Increment version to 3.15.2. * include/_mingw.h: Increment version to 3.15.2.

37
winsup/mingw/mingwex/getopt.c
View File

@ -328,18 +328,18 @@ int getopt_parse( int mode, getopt_std_args, ... )
* We will support it, by allowing the caller to adjust the value of * We will support it, by allowing the caller to adjust the value of
* `optind' downwards, (nominally setting it to zero). Since POSIX * `optind' downwards, (nominally setting it to zero). Since POSIX
* wants `optind' to have an initial value of one, but we want all * wants `optind' to have an initial value of one, but we want all
* of our internal placeholders to be initialised to zero, when we * of our internal place holders to be initialised to zero, when we
* are called for the first time, we will handle such a reset by * are called for the first time, we will handle such a reset by
* adjusting all of the internal placeholders to one less than the * adjusting all of the internal place holders to one less than
* adjusted `optind' value, (but never to less than zero). * the adjusted `optind' value, (but never to less than zero).
*/ */
if( optreset ) if( optreset )
{ {
/* User has explicitly requested reinitialisation... /* User has explicitly requested reinitialisation...
* We need to reset `optind' to it's normal initial value of 1, * We need to reset `optind' to it's normal initial value of 1,
* to avoid a potential infinitely recursive loop; by doing this * to avoid a potential infinitely recursive loop; by doing this
* up front, we also ensure that the remaining placeholders will * up front, we also ensure that the remaining place holders
* be correctly reinitialised to no less than zero. * will be correctly reinitialised to no less than zero.
*/ */
optind = 1; optind = 1;
@ -348,12 +348,37 @@ int getopt_parse( int mode, getopt_std_args, ... )
optreset = 0; optreset = 0;
} }
/* Now, we may safely reinitialise the internal placeholders, to /* Now, we may safely reinitialise the internal place holders, to
* one less than `optind', without fear of making them negative. * one less than `optind', without fear of making them negative.
*/ */
optmark = optbase = argind = optind - 1; optmark = optbase = argind = optind - 1;
nextchar = NULL; nextchar = NULL;
} }
/* From a POSIX perspective, the following is `undefined behaviour';
* we implement it thus, for compatibility with GNU and BSD getopt.
*/
else if( optind > (argind + 1) )
{
/* Some applications expect to be able to manipulate `optind',
* causing `getopt' to skip over one or more elements of `argv';
* POSIX doesn't require us to support this brain-damaged concept;
* (indeed, POSIX defines no particular behaviour, in the event of
* such usage, so it must be considered a bug for an application
* to rely on any particular outcome); nonetheless, Mac-OS-X and
* BSD actually provide *documented* support for this capability,
* so we ensure that our internal place holders keep track of
* external `optind' increments; (`argind' must lag by one).
*/
argind = optind - 1;
/* When `optind' is misused, in this fashion, we also abandon any
* residual text in the argument we had been parsing; this is done
* without any further processing of such abandoned text, assuming
* that the caller is equipped to handle it appropriately.
*/
nextchar = NULL;
}
if( nextchar && *nextchar ) if( nextchar && *nextchar )
{ {