From ca632c90157aaa0f0e00843bf8501c6831abe84b Mon Sep 17 00:00:00 2001 From: David Stacey Date: Wed, 27 May 2015 12:08:29 +0200 Subject: [PATCH] Fix potential memory leak in argz_replace Signed-off-by: Corinna Vinschen --- newlib/ChangeLog | 4 ++++ newlib/libc/argz/argz_replace.c | 5 ++++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/newlib/ChangeLog b/newlib/ChangeLog index a70fefea9..d1b0afec8 100644 --- a/newlib/ChangeLog +++ b/newlib/ChangeLog @@ -1,3 +1,7 @@ +2015-05-27 David Stacey + + * libc/argz/argz_replace.c: Fix potential memory leak. + 2015-05-26 DJ Delorie * libm/math/e_sqrt.c (__ieee754_sqrt): Don't truncate constant to diff --git a/newlib/libc/argz/argz_replace.c b/newlib/libc/argz/argz_replace.c index cb01eaef5..6bfd04b8a 100644 --- a/newlib/libc/argz/argz_replace.c +++ b/newlib/libc/argz/argz_replace.c @@ -71,7 +71,10 @@ _DEFUN (argz_replace, (argz, argz_len, str, with, replace_count), /* reallocate argz, and copy over the new value. */ if(!(*argz = (char *)realloc(*argz, new_argz_len))) - return ENOMEM; + { + free(new_argz); + return ENOMEM; + } memcpy(*argz, new_argz, new_argz_len); *argz_len = new_argz_len;