libs/newlib-cygwin
libs/newlib-cygwin
4
0
Fork 0
mirror of git://sourceware.org/git/newlib-cygwin.git synced 2025-02-15 05:29:10 +08:00
Code Issues Projects Releases Wiki Activity

Cygwin: unlink: fix error checking order

Browse Source 
Checking EPERM only makes sense if the file exists, so
let the EEXIST check change places with the EPERM check.

Add a debug statement to the EPERM condition.

Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
This commit is contained in:
Corinna Vinschen 2025-01-21 17:19:24 +01:00
parent 890086ad37
commit b879cd1661
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
winsup/cygwin/syscalls.cc
View File

@ -1136,17 +1136,18 @@ unlink (const char *ourname)
set_errno (EROFS); set_errno (EROFS);
goto done; goto done;
} }
if (!win32_name.isondisk ())
{
set_errno (EPERM);
goto done;
}
if (!win32_name.exists ()) if (!win32_name.exists ())
{ {
debug_printf ("unlinking a nonexistent file"); debug_printf ("unlinking a nonexistent file");
set_errno (ENOENT); set_errno (ENOENT);
goto done; goto done;
} }
if (!win32_name.isondisk ())
{
debug_printf ("unlinking a virtual file");
set_errno (EPERM);
goto done;
}
else if (win32_name.isdir ()) else if (win32_name.isdir ())
{ {
debug_printf ("unlinking a directory"); debug_printf ("unlinking a directory");