libs/newlib-cygwin
libs/newlib-cygwin
4
0
Fork 0
mirror of git://sourceware.org/git/newlib-cygwin.git synced 2025-02-13 12:39:22 +08:00
Code Issues Projects Releases Wiki Activity

Cygwin: AF_UNIX: evaluate_cmsg_data: more FIXMEs

Browse Source
This commit is contained in:
Ken Brown 2020-10-24 10:48:55 -04:00
parent 408636b186
commit b3cef213d8
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
winsup/cygwin/fhandler_socket_unix.cc
View File

@ -1937,11 +1937,15 @@ fhandler_socket_unix::evaluate_cmsg_data (af_unix_pkt_hdr_t *packet,
{ {
if (packet->cmsg_len != CMSG_SPACE (sizeof (struct ucred)) if (packet->cmsg_len != CMSG_SPACE (sizeof (struct ucred))
|| msg->msg_controllen < packet->cmsg_len) || msg->msg_controllen < packet->cmsg_len)
/* FIXME: What errno should we set? For example, if
packet->cmsg_len == 0, then we were expecting ancillary data
but didn't get any. */
return false; return false;
struct cmsghdr *cmsg = AF_UNIX_PKT_CMSG (packet); struct cmsghdr *cmsg = AF_UNIX_PKT_CMSG (packet);
if (!cmsg || cmsg->cmsg_len != CMSG_LEN (sizeof (struct ucred)) if (!cmsg || cmsg->cmsg_len != CMSG_LEN (sizeof (struct ucred))
|| cmsg->cmsg_level != SOL_SOCKET || cmsg->cmsg_level != SOL_SOCKET
|| cmsg->cmsg_type != SCM_CREDENTIALS) || cmsg->cmsg_type != SCM_CREDENTIALS)
/* FIXME: What errno should we set? */
return false; return false;
/* FIXME: Is this right? Do we just do nothing with no error /* FIXME: Is this right? Do we just do nothing with no error
indication? Or should we return false, causing recvmsg to fail? indication? Or should we return false, causing recvmsg to fail?