libs/newlib-cygwin
libs/newlib-cygwin
4
0
Fork 0
mirror of git://sourceware.org/git/newlib-cygwin.git synced 2025-02-21 00:07:36 +08:00
Code Issues Projects Releases Wiki Activity

Revert "Cygwin: set the FILE_ATTRIBUTE_ARCHIVE DOS attribute on file creation"

Browse Source 
This reverts commit 2b28977149b1e8858b597890906f21cdecde84ce.

This patch fixes the symptoms, but not the actual problem.  Revert
and try again.
This commit is contained in:
Corinna Vinschen 2021-11-16 18:36:27 +01:00
parent bff995a780
commit 9980177def
4 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
winsup/cygwin/exceptions.cc
View File

@ -157,7 +157,7 @@ cygwin_exception::open_stackdumpfile ()
NTSTATUS status; NTSTATUS status;
/* Try to open it to dump the stack in it. */ /* Try to open it to dump the stack in it. */
status = NtCreateFile (&h, GENERIC_WRITE | SYNCHRONIZE, &attr, &io, status = NtCreateFile (&h, GENERIC_WRITE | SYNCHRONIZE, &attr, &io,
NULL, FILE_ATTRIBUTE_ARCHIVE, 0, FILE_OVERWRITE_IF, NULL, FILE_ATTRIBUTE_NORMAL, 0, FILE_OVERWRITE_IF,
FILE_SYNCHRONOUS_IO_NONALERT FILE_SYNCHRONOUS_IO_NONALERT
| FILE_OPEN_FOR_BACKUP_INTENT, NULL, 0); | FILE_OPEN_FOR_BACKUP_INTENT, NULL, 0);
if (NT_SUCCESS (status)) if (NT_SUCCESS (status))

3
winsup/cygwin/fhandler.cc
View File

@ -649,8 +649,7 @@ fhandler_base::open (int flags, mode_t mode)
if (flags & (O_CREAT | O_TMPFILE)) if (flags & (O_CREAT | O_TMPFILE))
{ {
file_attributes |= (flags & O_TMPFILE) file_attributes |= FILE_ATTRIBUTE_NORMAL;
? FILE_ATTRIBUTE_NORMAL : FILE_ATTRIBUTE_ARCHIVE;
if (pc.fs_is_nfs ()) if (pc.fs_is_nfs ())
{ {

4
winsup/cygwin/path.cc
View File

@ -1945,7 +1945,7 @@ symlink_wsl (const char *oldpath, path_conv &win32_newpath)
status = NtCreateFile (&fh, DELETE | FILE_GENERIC_WRITE status = NtCreateFile (&fh, DELETE | FILE_GENERIC_WRITE
| READ_CONTROL | WRITE_DAC, | READ_CONTROL | WRITE_DAC,
win32_newpath.get_object_attr (attr, sec_none_nih), win32_newpath.get_object_attr (attr, sec_none_nih),
&io, NULL, FILE_ATTRIBUTE_ARCHIVE, &io, NULL, FILE_ATTRIBUTE_NORMAL,
FILE_SHARE_VALID_FLAGS, FILE_CREATE, FILE_SHARE_VALID_FLAGS, FILE_CREATE,
FILE_SYNCHRONOUS_IO_NONALERT FILE_SYNCHRONOUS_IO_NONALERT
| FILE_NON_DIRECTORY_FILE | FILE_NON_DIRECTORY_FILE
@ -2264,7 +2264,7 @@ symlink_worker (const char *oldpath, path_conv &win32_newpath, bool isdevice)
status = NtCreateFile (&fh, access, status = NtCreateFile (&fh, access,
win32_newpath.get_object_attr (attr, sec_none_nih), win32_newpath.get_object_attr (attr, sec_none_nih),
&io, NULL, FILE_ATTRIBUTE_ARCHIVE, &io, NULL, FILE_ATTRIBUTE_NORMAL,
FILE_SHARE_VALID_FLAGS, FILE_SHARE_VALID_FLAGS,
isdevice ? FILE_OVERWRITE_IF : FILE_CREATE, isdevice ? FILE_OVERWRITE_IF : FILE_CREATE,
FILE_SYNCHRONOUS_IO_NONALERT FILE_SYNCHRONOUS_IO_NONALERT

4
winsup/cygwin/release/3.3.3
View File

@ -13,10 +13,6 @@ Bug Fixes
- Fix showing DLL version info from native Windows tools. - Fix showing DLL version info from native Windows tools.
Addresses: https://cygwin.com/pipermail/cygwin/2021-November/249867.html Addresses: https://cygwin.com/pipermail/cygwin/2021-November/249867.html
- Fix long-standing problem that new files don't get created with the
FILE_ATTRIBUTE_ARCHIVE DOS attribute set.
Addresses: https://cygwin.com/pipermail/cygwin/2021-November/249909.html
- Handle Unicode surrogate pairs in console. Cygwin console does not - Handle Unicode surrogate pairs in console. Cygwin console does not
handle surrogate pairs correctly at the moment. Fix issue that handle surrogate pairs correctly at the moment. Fix issue that
running bash in Windows Terminal and inserting an emoji does not running bash in Windows Terminal and inserting an emoji does not