libs/newlib-cygwin
libs
/
newlib-cygwin
mirror of git://sourceware.org/git/newlib-cygwin.git
4
0
Fork 0
Code Issues Projects Releases Wiki Activity

Cygwin: ctty: Remove old 'kludge' code. 

Remove old 'kludge' code which does not seem necessary anymore. The
comment of the 'kludge' is as follows.

  * syscalls.cc (setsid): On second thought, in the spirit of keeping
    things kludgy, set ctty to -2 here as a special flag, and...
    (open): ...only eschew setting O_NOCTTY when that case is detected.

Fixes: c38a2d8373
Signed-off-by: Takashi Yano <takashi.yano@nifty.ne.jp>
This commit is contained in:
Takashi Yano 2023-03-05 18:17:39 +09:00
parent 13a84ac79b
commit 93f70d7849
2 changed files with 0 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
winsup/cygwin/dtable.cc
View File

@ -764,13 +764,6 @@ dtable::dup3 (int oldfd, int newfd, int flags)
return -1; return -1;
} }
/* This is a temporary kludge until all utilities can catch up with
a change in behavior that implements linux functionality: opening
a tty should not automatically cause it to become the controlling
tty for the process. */
if (newfd > 2)
flags |= O_NOCTTY;
if ((newfh = dup_worker (fds[oldfd], flags)) == NULL) if ((newfh = dup_worker (fds[oldfd], flags)) == NULL)
{ {
res = -1; res = -1;

11
winsup/cygwin/syscalls.cc
View File

@ -1450,17 +1450,6 @@ open (const char *unix_path, int flags, ...)
int opt = PC_OPEN | PC_SYM_NOFOLLOW_PROCFD; int opt = PC_OPEN | PC_SYM_NOFOLLOW_PROCFD;
opt |= (flags & (O_NOFOLLOW | O_EXCL)) ? PC_SYM_NOFOLLOW opt |= (flags & (O_NOFOLLOW | O_EXCL)) ? PC_SYM_NOFOLLOW
: PC_SYM_FOLLOW; : PC_SYM_FOLLOW;
/* This is a temporary kludge until all utilities can catch up
with a change in behavior that implements linux functionality:
opening a tty should not automatically cause it to become the
controlling tty for the process. */
if (!(flags & O_NOCTTY) && fd > 2 && myself->ctty != -2)
{
flags |= O_NOCTTY;
/* flag that, if opened, this fhandler could later be capable
of being a controlling terminal if /dev/tty is opened. */
opt |= PC_CTTY;
}
/* If we're opening a FIFO, we will call device_access_denied /* If we're opening a FIFO, we will call device_access_denied
below. This leads to a call to fstat, which can use the below. This leads to a call to fstat, which can use the