libs/newlib-cygwin
libs/newlib-cygwin
4
0
Fork 0
mirror of git://sourceware.org/git/newlib-cygwin.git synced 2025-02-13 04:29:09 +08:00
Code Issues Projects Releases Wiki Activity

Cygwin: console: Add error handling for thread_sync_event

Browse Source 
Signed-off-by: Takashi Yano <takashi.yano@nifty.ne.jp>
This commit is contained in:
Takashi Yano 2024-06-29 19:03:20 +09:00
parent 40f751e1f4
commit 936c062446
1 changed files with 34 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

51
winsup/cygwin/fhandler/console.cc
View File

@ -272,17 +272,23 @@ cons_master_thread (VOID *arg)
fhandler_console::handle_set_t handle_set; fhandler_console::handle_set_t handle_set;
fh->get_duplicated_handle_set (&handle_set); fh->get_duplicated_handle_set (&handle_set);
HANDLE thread_sync_event; HANDLE thread_sync_event;
DuplicateHandle (GetCurrentProcess (), fh->thread_sync_event, if (DuplicateHandle (GetCurrentProcess (), fh->thread_sync_event,
GetCurrentProcess (), &thread_sync_event, GetCurrentProcess (), &thread_sync_event,
0, FALSE, DUPLICATE_SAME_ACCESS); 0, FALSE, DUPLICATE_SAME_ACCESS))
SetEvent (thread_sync_event); {
master_thread_started = true; SetEvent (thread_sync_event);
/* Do not touch class members after here because the class instance master_thread_started = true;
may have been destroyed. */ /* Do not touch class members after here because the class instance
fhandler_console::cons_master_thread (&handle_set, ttyp); may have been destroyed. */
fhandler_console::close_handle_set (&handle_set); fhandler_console::cons_master_thread (&handle_set, ttyp);
SetEvent (thread_sync_event); fhandler_console::close_handle_set (&handle_set);
CloseHandle (thread_sync_event); SetEvent (thread_sync_event);
CloseHandle (thread_sync_event);
master_thread_started = false;
}
else
debug_printf ("cons_master_thread not started because thread_sync_event "
"could not be duplicated %08x", GetLastError ());
return 0; return 0;
} }
@ -451,6 +457,8 @@ fhandler_console::cons_master_thread (handle_set_t *p, tty *ttyp)
case WAIT_CANCELED: case WAIT_CANCELED:
break; break;
default: /* Error */ default: /* Error */
free (input_rec);
free (input_tmp);
ReleaseMutex (p->input_mutex); ReleaseMutex (p->input_mutex);
return; return;
} }
@ -1847,9 +1855,12 @@ fhandler_console::open (int flags, mode_t)
char name[MAX_PATH]; char name[MAX_PATH];
shared_name (name, CONS_THREAD_SYNC, get_minor ()); shared_name (name, CONS_THREAD_SYNC, get_minor ());
thread_sync_event = CreateEvent(NULL, FALSE, FALSE, name); thread_sync_event = CreateEvent(NULL, FALSE, FALSE, name);
new cygthread (::cons_master_thread, this, "consm"); if (thread_sync_event)
WaitForSingleObject (thread_sync_event, INFINITE); {
CloseHandle (thread_sync_event); new cygthread (::cons_master_thread, this, "consm");
WaitForSingleObject (thread_sync_event, INFINITE);
CloseHandle (thread_sync_event);
}
} }
return 1; return 1;
} }
@ -1910,9 +1921,15 @@ fhandler_console::close ()
char name[MAX_PATH]; char name[MAX_PATH];
shared_name (name, CONS_THREAD_SYNC, get_minor ()); shared_name (name, CONS_THREAD_SYNC, get_minor ());
thread_sync_event = OpenEvent (MAXIMUM_ALLOWED, FALSE, name); thread_sync_event = OpenEvent (MAXIMUM_ALLOWED, FALSE, name);
con.owner = MAX_PID + 1; if (thread_sync_event)
WaitForSingleObject (thread_sync_event, INFINITE); {
CloseHandle (thread_sync_event); con.owner = MAX_PID + 1;
WaitForSingleObject (thread_sync_event, INFINITE);
CloseHandle (thread_sync_event);
}
else
debug_printf ("Failed to open thread_sync_event %08x",
GetLastError ());
} }
con.owner = 0; con.owner = 0;
} }