libs/newlib-cygwin
libs
/
newlib-cygwin
mirror of git://sourceware.org/git/newlib-cygwin.git
4
0
Fork 0
Code Issues Projects Releases Wiki Activity

Cygwin: fix rename in container 

Renaming files returns STATUS_INVALID_PARAMETE on a bind mounted file system
in hyper-v container with FILE_RENAME_POSIX_SEMANTICS.

Disable the use_posix_semantics flag and retry.

Signed-off-by: Yoshinao Muramatsu <ysno@ac.auone-net.jp>
This commit is contained in:
Yoshinao Muramatsu 2023-03-20 20:51:01 +09:00 committed by Corinna Vinschen
parent 527dd1b407
commit 7666e248dd
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
winsup/cygwin/syscalls.cc
View File

@ -2419,6 +2419,7 @@ rename2 (const char *oldpath, const char *newpath, unsigned int at2flags)
&& oldpc.fs_is_ntfs ()
&& oldpc.has_attribute (FILE_SUPPORTS_OPEN_BY_FILE_ID);
ignore_posix_semantics_retry:
/* Opening the file must be part of the transaction. It's not sufficient
to call only NtSetInformationFile under the transaction. Therefore we
have to start the transaction here, if necessary. Don't start
@ -2663,6 +2664,15 @@ skip_pre_W10_checks:
unlink_nt (*removepc, false);
res = 0;
}
else if (use_posix_semantics && status == STATUS_INVALID_PARAMETER)
{
/* NtSetInformationFile returns STATUS_INVALID_PARAMETER
on a bind mounted file system in hyper-v container
with FILE_RENAME_POSIX_SEMANTICS.
Disable the use_posix semntics flag and retry. */
use_posix_semantics = 0;
goto ignore_posix_semantics_retry;
}
else
__seterrno_from_nt_status (status);
}