libs/newlib-cygwin
libs
/
newlib-cygwin
mirror of git://sourceware.org/git/newlib-cygwin.git
4
0
Fork 0
Code Issues Projects Releases Wiki Activity

Cygwin: fork: restrict parent handle perms and drop handle after use 

Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
This commit is contained in:
Corinna Vinschen 2019-01-27 13:15:15 +01:00
parent 0fb497165f
commit 69cc7a0686
3 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
winsup/cygwin/dcrt0.cc
View File

@ -637,7 +637,8 @@ child_info_fork::handle_fork ()
bool bool
child_info_spawn::get_parent_handle () child_info_spawn::get_parent_handle ()
{ {
parent = OpenProcess (PROCESS_VM_READ, false, parent_winpid); parent = OpenProcess (PROCESS_QUERY_LIMITED_INFORMATION, FALSE,
parent_winpid);
moreinfo->myself_pinfo = NULL; moreinfo->myself_pinfo = NULL;
return !!parent; return !!parent;
} }

2
winsup/cygwin/fork.cc
View File

@ -203,6 +203,8 @@ frok::child (volatile char * volatile here)
rd_proc_pipe that would be an invalid handle. In the case of rd_proc_pipe that would be an invalid handle. In the case of
wr_proc_pipe it would be == my_wr_proc_pipe. Both would be bad. */ wr_proc_pipe it would be == my_wr_proc_pipe. Both would be bad. */
ch.rd_proc_pipe = ch.wr_proc_pipe = NULL; ch.rd_proc_pipe = ch.wr_proc_pipe = NULL;
CloseHandle (hParent);
hParent = NULL;
cygwin_finished_initializing = true; cygwin_finished_initializing = true;
return 0; return 0;
} }

5
winsup/cygwin/sigproc.cc
View File

@ -814,8 +814,9 @@ child_info::child_info (unsigned in_cb, child_info_types chtype,
allow the child to duplicate handles from the parent to itself. */ allow the child to duplicate handles from the parent to itself. */
parent = NULL; parent = NULL;
if (!DuplicateHandle (GetCurrentProcess (), GetCurrentProcess (), if (!DuplicateHandle (GetCurrentProcess (), GetCurrentProcess (),
GetCurrentProcess (), &parent, 0, true, GetCurrentProcess (), &parent,
DUPLICATE_SAME_ACCESS)) PROCESS_DUP_HANDLE | PROCESS_VM_READ
| PROCESS_QUERY_LIMITED_INFORMATION, TRUE, 0))
system_printf ("couldn't create handle to myself for child, %E"); system_printf ("couldn't create handle to myself for child, %E");
} }