libs/newlib-cygwin
libs/newlib-cygwin
4
0
Fork 0
mirror of git://sourceware.org/git/newlib-cygwin.git synced 2025-01-19 04:49:25 +08:00
Code Issues Projects Releases Wiki Activity

a) Use strcoll() in opendir() and alphasort()

Browse Source 
as POSIX 2008 requires. It also matches now how our 'ls' works for years.

b) Remove comment expressed 2 fears:
 1) One just simple describe how strcoll() works in _any_ context,
 not for directories only. Are we plan to remove strcoll() from everything
 just because it is little more complex than strcmp()? I doubt, and
 directories give nothing different here. Moreover, strcoll() used
 in 'ls' for years and nobody complaints yet.

 2) Plain wrong statement about undefined strcoll() behaviour. strcoll()
 always gives predictable results, falling back to strcmp() on any
 trouble, see strcoll(3).

No objections from -current list discussion.
This commit is contained in:
ache 2010-01-18 10:17:51 +00:00 committed by Sebastian Huber
parent 2d3c2f4697
commit 67613cbbd8
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
newlib/libc/posix/scandir.c
View File

@ -142,12 +142,13 @@ fail:
/*
* Alphabetic order comparison routine for those who want it.
* POSIX 2008 requires that alphasort() uses strcoll().
*/
int
alphasort (const struct dirent **d1,
const struct dirent **d2)
alphasort(const struct dirent **d1, const struct dirent **d2)
{
return(strcmp((*d1)->d_name, (*d2)->d_name));
return (strcoll((*d1)->d_name, (*d2)->d_name));
}
#endif /* ! HAVE_OPENDIR */