4
0
mirror of git://sourceware.org/git/newlib-cygwin.git synced 2025-01-31 11:30:56 +08:00

Cygwin: pty: Fix memory leak in master_fwd_thread.

- If master_fwd_thread is terminated by cygthread::terminate_thread(),
  the opportunity to release tmp_pathbuf is missed, resulting in a
  memory leak. This patch fixes the issue.
This commit is contained in:
Takashi Yano 2022-01-13 18:18:00 +09:00
parent aa49985245
commit 4f490c4cef
3 changed files with 7 additions and 1 deletions

View File

@ -2106,7 +2106,9 @@ fhandler_pty_master::close ()
master_ctl = NULL;
}
release_output_mutex ();
master_fwd_thread->terminate_thread ();
get_ttyp ()->stop_fwd_thread = true;
WriteFile (to_master_nat, "", 0, NULL, NULL);
master_fwd_thread->detach ();
}
}
if (InterlockedDecrement (&master_cnt) == 0)
@ -2695,6 +2697,8 @@ fhandler_pty_master::pty_master_fwd_thread (const master_fwd_thread_param_t *p)
termios_printf ("ReadFile for forwarding failed, %E");
break;
}
if (p->ttyp->stop_fwd_thread)
break;
ssize_t wlen = rlen;
char *ptr = outbuf;
if (p->ttyp->pcon_activated)

View File

@ -254,6 +254,7 @@ tty::init ()
last_sig = 0;
mask_flusho = false;
discard_input = false;
stop_fwd_thread = false;
}
HANDLE

View File

@ -132,6 +132,7 @@ private:
xfer_dir pcon_input_state;
bool mask_flusho;
bool discard_input;
bool stop_fwd_thread;
public:
HANDLE from_master_nat () const { return _from_master_nat; }