libs/newlib-cygwin
libs/newlib-cygwin
4
0
Fork 0
mirror of git://sourceware.org/git/newlib-cygwin.git synced 2025-01-19 04:49:25 +08:00
Code Issues Projects Releases Wiki Activity

Cygwin: normalize_posix_path: fix error handling when .. is encountered

Browse Source 
When .. is in the source path and the path prefix exists but is not a
directory, return ENOTDIR instead of ENOENT.  This fixes a POSIX
compliance issue for realpath(3):

  https://pubs.opengroup.org/onlinepubs/9699919799/functions/realpath.html

Addresses: https://lists.gnu.org/archive/html/bug-gnulib/2021-01/msg00214.html
This commit is contained in:
Ken Brown 2021-01-20 10:12:58 -05:00
parent 0c0ff5dc21
commit 4aefad2bb8
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
winsup/cygwin/path.cc
View File

@ -323,8 +323,10 @@ normalize_posix_path (const char *src, char *dst, char *&tail)
if (!tp.check_usage (4, 3))
return ELOOP;
path_conv head (dst, PC_SYM_FOLLOW | PC_POSIX);
if (!head.isdir())
if (!head.exists ())
return ENOENT;
if (!head.isdir ())
return ENOTDIR;
/* At this point, dst is a normalized path. If the
normalized path created by path_conv does not
match the normalized path we're just testing, then

4
winsup/cygwin/release/3.2.0
View File

@ -48,3 +48,7 @@ Bug Fixes
- Fix a bug in fstatat(2) on 32 bit that could cause it to return garbage.
Addresses: https://cygwin.com/pipermail/cygwin/2021-January/247399.html
- Fix the errno when a path contains .. and the prefix exists but is
not a directory.
Addresses: https://lists.gnu.org/archive/html/bug-gnulib/2021-01/msg00214.html