libs/newlib-cygwin
libs/newlib-cygwin
4
0
Fork 0
mirror of git://sourceware.org/git/newlib-cygwin.git synced 2025-02-21 00:07:36 +08:00
Code Issues Projects Releases Wiki Activity

* exceptions.cc (try_to_debug): Improve comment.

Browse Source 
* fhandler_tty.cc (fhandler_pty_master::fhandler_pty_master): Add a comment.
This commit is contained in:
Christopher Faylor 2010-10-24 15:26:05 +00:00
parent c4f296c2a9
commit 488ddaced3
3 changed files with 13 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
winsup/cygwin/ChangeLog
View File

@ -1,3 +1,9 @@
2010-10-24 Christopher Faylor <me+cygwin@cgf.cx>
* exceptions.cc (try_to_debug): Improve comment.
* fhandler_tty.cc (fhandler_pty_master::fhandler_pty_master): Add a
comment.
2010-10-23 Christopher Faylor <me+cygwin@cgf.cx> 2010-10-23 Christopher Faylor <me+cygwin@cgf.cx>
* pinfo.cc (pinfo::exit): Grab a tty lock before setting pgid. * pinfo.cc (pinfo::exit): Grab a tty lock before setting pgid.

5
winsup/cygwin/exceptions.cc
View File

@ -390,8 +390,9 @@ try_to_debug (bool waitloop)
suspend_all_threads_except (current_thread_id); suspend_all_threads_except (current_thread_id);
*/ */
/* if any of these mutexes is owned, we will fail to start any cygwin app /* If the tty mutex is owned, we will fail to start any cygwin app
until trapped app exits */ until the trapped app exits. However, this will only release any
the mutex if it is owned by this thread so that may be problematic. */
lock_ttys::release (); lock_ttys::release ();

8
winsup/cygwin/fhandler_tty.cc
View File

@ -1347,8 +1347,8 @@ fhandler_pty_master::fhandler_pty_master ()
int int
fhandler_pty_master::open (int flags, mode_t) fhandler_pty_master::open (int flags, mode_t)
{ {
int ntty; /* Note that allocate returns with the tty lock set if it was successful. */
ntty = cygwin_shared->tty.allocate (false); int ntty = cygwin_shared->tty.allocate (false);
if (ntty < 0) if (ntty < 0)
return 0; return 0;
@ -1361,8 +1361,8 @@ fhandler_pty_master::open (int flags, mode_t)
lock_ttys::release (); lock_ttys::release ();
set_flags ((flags & ~O_TEXT) | O_BINARY); set_flags ((flags & ~O_TEXT) | O_BINARY);
set_open_status (); set_open_status ();
//
// FIXME: Do this better someday /* FIXME: Do this better someday */
fhandler_pty_master *arch = (fhandler_tty_master *) cmalloc_abort (HEAP_ARCHETYPES, sizeof (*this)); fhandler_pty_master *arch = (fhandler_tty_master *) cmalloc_abort (HEAP_ARCHETYPES, sizeof (*this));
*((fhandler_pty_master **) cygheap->fdtab.add_archetype ()) = arch; *((fhandler_pty_master **) cygheap->fdtab.add_archetype ()) = arch;
archetype = arch; archetype = arch;