* fhandler_console.cc (fhandler_console::close): Remove obsolete test for

vfork_cleanup.
* pipe.cc (fhandler_pipe::close): Add comment.
This commit is contained in:
Christopher Faylor 2004-01-17 03:47:27 +00:00
parent 49d0c04260
commit 46ee54222e
3 changed files with 10 additions and 2 deletions

View File

@ -1,3 +1,9 @@
2004-01-16 Christopher Faylor <cgf@redhat.com>
* fhandler_console.cc (fhandler_console::close): Remove obsolete test
for vfork_cleanup.
* pipe.cc (fhandler_pipe::close): Add comment.
2004-01-16 Christopher Faylor <cgf@redhat.com>
* cygheap.cc (init_cygheap::close_ctty): Don't NULL ctty if it is still

View File

@ -677,8 +677,7 @@ fhandler_console::close (void)
CloseHandle (get_output_handle ());
set_io_handle (NULL);
set_output_handle (NULL);
if (!cygheap->fdtab.in_vfork_cleanup () && --(cygheap->open_fhs) <= 0
&& myself->ctty != TTY_CONSOLE)
if (--(cygheap->open_fhs) <= 0 && myself->ctty != TTY_CONSOLE)
{
syscall_printf ("open_fhs %d", cygheap->open_fhs);
FreeConsole ();

View File

@ -89,6 +89,9 @@ fhandler_pipe::close ()
CloseHandle (guard);
if (writepipe_exists)
CloseHandle (writepipe_exists);
// FIXME is this vfork_cleanup test right? Is it responsible for some of
// the strange pipe behavior that has been reported in the cygwin mailing
// list?
if (read_state && !cygheap->fdtab.in_vfork_cleanup ())
CloseHandle (read_state);
if (get_handle ())