From 398476acd2dca8d68044e1b6e68eb41a16086f79 Mon Sep 17 00:00:00 2001 From: Ken Brown Date: Mon, 26 Aug 2019 13:38:31 -0400 Subject: [PATCH] Cygwin: get_posix_access: avoid negative subscript Don't refer to lacl[pos] unless we know that pos >= 0. --- winsup/cygwin/sec_acl.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/winsup/cygwin/sec_acl.cc b/winsup/cygwin/sec_acl.cc index 933bfa69d..67749d7b1 100644 --- a/winsup/cygwin/sec_acl.cc +++ b/winsup/cygwin/sec_acl.cc @@ -807,9 +807,9 @@ get_posix_access (PSECURITY_DESCRIPTOR psd, lacl[pos].a_id = ACL_UNDEFINED_ID; lacl[pos].a_perm = CYG_ACE_MASK_TO_POSIX (ace->Mask); aclsid[pos] = well_known_null_sid; + has_class_perm = true; + class_perm = lacl[pos].a_perm; } - has_class_perm = true; - class_perm = lacl[pos].a_perm; } if (ace->Header.AceFlags & SUB_CONTAINERS_AND_OBJECTS_INHERIT) { @@ -820,9 +820,9 @@ get_posix_access (PSECURITY_DESCRIPTOR psd, lacl[pos].a_id = ACL_UNDEFINED_ID; lacl[pos].a_perm = CYG_ACE_MASK_TO_POSIX (ace->Mask); aclsid[pos] = well_known_null_sid; + has_def_class_perm = true; + def_class_perm = lacl[pos].a_perm; } - has_def_class_perm = true; - def_class_perm = lacl[pos].a_perm; } } }