Fix vfwscanf(3) assignment suppression flag handling bug

newlib's vfwscanf(3) (or specifically, __SVFWSCANF_R()) fails to correctly set
the assignment-suppressing character (`*') flag[1] which, when present in the
formatting string, results in undefined behaviour comprising retrieving and
dereferencing a pointer that was not supplied by the caller as such or at all.
When compared to the vfscanf(3) implementation, this would appear to be over
the missing goto match_failure statement preceded by the flags test seen below.
Hence, this patch (re)introduces it.

[1] <http://pubs.opengroup.org/onlinepubs/009695399/functions/fwscanf.html>

--
This commit is contained in:
Lucio Andrés Illanes Albornoz 2019-06-01 10:33:19 +02:00 committed by Ken Brown
parent 1770da2dab
commit 3564641506
1 changed files with 1 additions and 0 deletions

View File

@ -602,6 +602,7 @@ __SVFWSCANF_R (struct _reent *rptr,
case L'*':
if ((flags & (CHAR | SHORT | LONG | LONGDBL | SUPPRESS | MALLOC))
|| width)
goto match_failure;
flags |= SUPPRESS;
goto again;
case L'l':