libs/newlib-cygwin
libs
/
newlib-cygwin
mirror of git://sourceware.org/git/newlib-cygwin.git
4
0
Fork 0
Code Issues Projects Releases Wiki Activity

Cygwin: Change pthread_sigqueue() to accept thread id 

Change the first parameter of pthread_sigqueue() to be a thread id rather
than a thread pointer. The change is to match the Linux implementation of
this function.

The user-visible function prototype is changed in include/pthread.h.
The pthread_sigqueue() function is modified to work with a passed-in thread
id rather than an indirect thread pointer as before.  (It used to be
"pthread_t *thread", i.e., class pthread **.)  The release note for Cygwin
3.5.5 is updated.

Reported-by: Christian Franke <Christian.Franke@t-online.de>
Addresses: https://cygwin.com/pipermail/cygwin/2024-September/256439.html
Signed-off-by: Mark Geisert <mark@maxrnd.com>
Fixes: 50350cafb3 ("* cygwin.din (pthread_sigqueue): Export.")
This commit is contained in:
Mark Geisert 2024-11-11 22:38:29 -08:00 committed by Corinna Vinschen
parent 87cd4f3fbd
commit 1e8c92e21d
3 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
winsup/cygwin/include/pthread.h
View File

@ -247,7 +247,7 @@ int pthread_getattr_np (pthread_t, pthread_attr_t *);
int pthread_getname_np (pthread_t, char *, size_t) __attribute__((__nonnull__(2)));
int pthread_setaffinity_np (pthread_t, size_t, const cpu_set_t *);
int pthread_setname_np (pthread_t, const char *) __attribute__((__nonnull__(2)));
int pthread_sigqueue (pthread_t *, int, const union sigval);
int pthread_sigqueue (pthread_t, int, const union sigval);
int pthread_timedjoin_np (pthread_t, void **, const struct timespec *);
int pthread_tryjoin_np (pthread_t, void **);
#endif

3
winsup/cygwin/release/3.5.5
View File

@ -30,3 +30,6 @@ Fixes:
- Fix a problem that signal handler destroys the FPU context.
Addresses: https://cygwin.com/pipermail/cygwin/2024-October/256503.html
- Fix type of pthread_sigqueue() first parameter to match Linux.
Addresses: https://cygwin.com/pipermail/cygwin/2024-September/256439.html

8
winsup/cygwin/thread.cc
View File

@ -3301,13 +3301,13 @@ pthread_sigmask (int operation, const sigset_t *set, sigset_t *old_set)
}
int
pthread_sigqueue (pthread_t *thread, int sig, const union sigval value)
pthread_sigqueue (pthread_t thread, int sig, const union sigval value)
{
siginfo_t si = {0};
if (!pthread::is_good_object (thread))
if (!pthread::is_good_object (&thread))
return EINVAL;
if (!(*thread)->valid)
if (!thread->valid)
return ESRCH;
si.si_signo = sig;
@ -3315,7 +3315,7 @@ pthread_sigqueue (pthread_t *thread, int sig, const union sigval value)
si.si_value = value;
si.si_pid = myself->pid;
si.si_uid = myself->uid;
return (int) sig_send (NULL, si, (*thread)->cygtls);
return (int) sig_send (NULL, si, thread->cygtls);
}
/* Cancelability */