libs/newlib-cygwin
libs/newlib-cygwin
4
0
Fork 0
mirror of git://sourceware.org/git/newlib-cygwin.git synced 2025-02-02 04:20:28 +08:00
Code Issues Projects Releases Wiki Activity

Cygwin: fsync: Fix EINVAL for block device.

Browse Source 
The commit af8a7c13b516 has a problem that fsync returns EINVAL for
block device. This patch treats block devices as a special case.
https://cygwin.com/pipermail/cygwin/2023-January/252916.html

Fixes: af8a7c13b516 ("Cygwin: fsync: Return EINVAL for special files.")
Reported-by: Yano Ray <yanorei@hotmail.co.jp>
Reviewed-by: Corinna Vinschen <corinna@vinschen.de>
Signed-off-by: Takashi Yano <takashi.yano@nifty.ne.jp>
This commit is contained in:
Takashi Yano 2023-01-21 21:33:03 +09:00
parent 5889a3cede
commit 17ad18afc6
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
winsup/cygwin/fhandler/base.cc
View File

@ -1728,7 +1728,8 @@ fhandler_base::utimens (const struct timespec *tvp)
int
fhandler_base::fsync ()
{
if (!get_handle () || nohandle () || pc.isspecial ())
if (!get_handle () || nohandle ()
|| (pc.isspecial () && !S_ISBLK (pc.dev.mode ())))
{
set_errno (EINVAL);
return -1;

5
winsup/cygwin/release/3.4.6 Normal file
View File

@ -0,0 +1,5 @@
Bug Fixes
---------
Fix a problem that fsync returns EINVAL for block device.
Addresses: https://cygwin.com/pipermail/cygwin/2023-January/252916.html