libs/newlib-cygwin
libs/newlib-cygwin
4
0
Fork 0
mirror of git://sourceware.org/git/newlib-cygwin.git synced 2025-02-22 00:38:06 +08:00
Code Issues Projects Releases Wiki Activity

* uinfo.cc (pwdgrp::fetch_account_from_windows): Fix comment.

Browse Source
This commit is contained in:
Corinna Vinschen 2014-07-30 14:23:53 +00:00
parent dea309cf1f
commit 1721a38efd
2 changed files with 11 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
winsup/cygwin/ChangeLog
View File

@ -1,3 +1,7 @@
2014-07-30 Corinna Vinschen <corinna@vinschen.de>
* uinfo.cc (pwdgrp::fetch_account_from_windows): Fix comment.
2014-07-29 Corinna Vinschen <corinna@vinschen.de> 2014-07-29 Corinna Vinschen <corinna@vinschen.de>
* cygheap.h (class cygheap_domain_info): Remove lowest_tdo_posix_offset. * cygheap.h (class cygheap_domain_info): Remove lowest_tdo_posix_offset.

15
winsup/cygwin/uinfo.cc
View File

@ -1530,14 +1530,13 @@ pwdgrp::fetch_account_from_windows (fetch_user_arg_t &arg, cyg_ldap *pldap)
{ {
posix_offset = PRIMARY_POSIX_OFFSET; posix_offset = PRIMARY_POSIX_OFFSET;
/* In theory domain should have been set to /* In theory domain should have been set to
cygheap->dom.primary_dns_name (), but it turns out cygheap->dom.primary_dns_name (), but it turns out that
that not setting the domain here has advantages. not setting the domain here has advantages. We open the
We open the ldap connection to NULL (== some domain ldap connection to NULL (== some DC of our primary domain)
control of our primary domain) anyway. So the domain anyway. So the domain is only used later on. So, don't
is only used set domain here to non-NULL, unless you're sure you have
later on. So, don't set domain here to non-NULL, unless also changed subsequent assumptions that domain is NULL
you're sure you have also changed subsequent assumptions if it's a primary domain account. */
that domain is NULL if it's a primary domain account. */
if (!cygheap->pg.nss_prefix_auto ()) if (!cygheap->pg.nss_prefix_auto ())
name_style = fully_qualified; name_style = fully_qualified;
} }