libs/newlib-cygwin
libs
/
newlib-cygwin
mirror of git://sourceware.org/git/newlib-cygwin.git
4
0
Fork 0
Code Issues Projects Releases Wiki Activity

Cygwin: cygserver: drop useless packed attribute 

...from structs used for data exchange between clients and cygserver.
All of the structs have the same size and member offsets, packed or
unpacked.  Keeping the packed attribute results in ominous warnings
from gcc-9.2.0:

  cygserver.cc:259:10: warning: taking address of packed member of
  'client_request_attach_tty::request_attach_tty' may result in an
  unaligned pointer value [-Waddress-of-packed-member]

Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
This commit is contained in:
Corinna Vinschen 2020-02-26 20:52:55 +01:00
parent 5f66c2c756
commit 0a37e9f0bc
1 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
winsup/cygwin/cygserver.h
View File

@ -11,12 +11,6 @@ details. */
#ifndef _CYGSERVER_H_
#define _CYGSERVER_H_
#ifdef __GNUC__
#define CYGSERVER_PACKED __attribute__ ((packed))
#else
#define CYGSERVER_PACKED
#endif
#define CYGWIN_SERVER_VERSION_MAJOR 1
#define CYGWIN_SERVER_VERSION_API 4
#define CYGWIN_SERVER_VERSION_MINOR 0
@ -65,7 +59,7 @@ protected:
header_t () {};
header_t (request_code_t, size_t);
} CYGSERVER_PACKED;
};
public:
#ifndef __INSIDE_CYGWIN__
@ -111,7 +105,7 @@ private:
struct request_get_version
{
DWORD major, api, minor, patch;
} CYGSERVER_PACKED;
};
public:
client_request_get_version ();
@ -156,7 +150,7 @@ private:
{
DWORD pid, master_pid;
HANDLE from_master, to_master;
} CYGSERVER_PACKED;
};
public:
#ifdef __INSIDE_CYGWIN__