From 0795a24552591dec14b4850b0a3bdd653bee30c9 Mon Sep 17 00:00:00 2001 From: Christopher Faylor Date: Sat, 9 Oct 2004 23:19:38 +0000 Subject: [PATCH] * cygcheck.cc (dump_sysinfo): Warn about trailing (back)slash on mount entries. --- winsup/utils/ChangeLog | 5 +++++ winsup/utils/cygcheck.cc | 6 ++++++ 2 files changed, 11 insertions(+) diff --git a/winsup/utils/ChangeLog b/winsup/utils/ChangeLog index 71dc22d16..5724ec689 100644 --- a/winsup/utils/ChangeLog +++ b/winsup/utils/ChangeLog @@ -1,3 +1,8 @@ +2004-10-10 Bas van Gompel + + * cygcheck.cc (dump_sysinfo): Warn about trailing (back)slash on mount + entries. + 2004-10-10 Bas van Gompel * cygcheck.cc (dump_sysinfo): Don't warn about empty path components, diff --git a/winsup/utils/cygcheck.cc b/winsup/utils/cygcheck.cc index 1681b9724..17b9d948d 100644 --- a/winsup/utils/cygcheck.cc +++ b/winsup/utils/cygcheck.cc @@ -1165,19 +1165,25 @@ dump_sysinfo () printf ("\n"); unsigned ml_fsname = 4, ml_dir = 7, ml_type = 6; + bool ml_trailing = false; struct mntent *mnt; setmntent (0, 0); while ((mnt = getmntent (0))) { unsigned n = (int) strlen (mnt->mnt_fsname); + ml_trailing |= (n > 1 && strchr ("\\/", mnt->mnt_fsname[n - 1])); if (ml_fsname < n) ml_fsname = n; n = (int) strlen (mnt->mnt_dir); + ml_trailing |= (n > 1 && strchr ("\\/", mnt->mnt_dir[n - 1])); if (ml_dir < n) ml_dir = n; } + if (ml_trailing) + puts ("Warning: Mount entries should not have a trailing (back)slash\n"); + if (givehelp) { printf